Bugfix for invalidate_hard_deletes=True directive used in dbt snapshots #38
+135
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In dbt snapshots, rows that are deleted from the source query are not invalidated by default.
With the config option
invalidate_hard_deletes=True, dbt can track rows that no longer exist.The fix was to change a line in the snapshot macro because SQL generated raised
ORA-00905: missing keywordThe following line
is changed to
Also added a new test case in the suite to test invalidation of hard deletes in dbt snapshots